Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update DS name mappings #2563

Merged
merged 2 commits into from
Feb 10, 2025
Merged

chore: update DS name mappings #2563

merged 2 commits into from
Feb 10, 2025

Conversation

cordeliadillon
Copy link
Contributor

Fixes #2486

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Update the Design System canonical name mappings for some Skin modules, so that they map to the appropriate Evo Design System components

Notes

This PR is only for some name mapping changes. The original ticket also mentioned version numbers, but I'd like to wait and do that in another PR after we've buttoned up some version tidying on the design system side.

This PR does not fix #2561.

Screenshots

N/A

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue

Copy link

changeset-bot bot commented Feb 5, 2025

🦋 Changeset detected

Latest commit: cb8c8f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cordeliadillon cordeliadillon requested a review from agliga February 5, 2025 21:21
@cordeliadillon
Copy link
Contributor Author

@agliga, thanks for the review! Could someone from your team merge this in when you all get a chance? Thanks!

@agliga agliga merged commit 1b316bd into 19.1.0 Feb 10, 2025
@agliga agliga deleted the 2486-canonical-names branch February 10, 2025 21:02
@github-actions github-actions bot mentioned this pull request Feb 10, 2025
@github-actions github-actions bot mentioned this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants